> On Sept. 10, 2013, 2:34 p.m., David Faure wrote: > > khtml/khtml_part.cpp, line 1060 > > <http://git.reviewboard.kde.org/r/112559/diff/4/?file=188611#file188611line1060> > > > > I just realized that KIO::storedGet + job->exec() would remove the need > > for a temporary file altogether :-) > > > > But OK leave it as that if you want to move on.
The thing is... as with the "let's keep the bug" I don't want to modify much khtml code, so I'm trying to keep it as close as the original one. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/#review39721 ----------------------------------------------------------- On Sept. 10, 2013, 1:56 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112559/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 1:56 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Port the rest of kdelibs-frameworks to KIO/Jobs > > > Diffs > ----- > > khtml/ecma/xmlhttprequest.h 6edf708 > khtml/ecma/xmlhttprequest.cpp 565b489 > khtml/html/html_formimpl.cpp 1a16a77 > khtml/khtml_part.cpp 1833e4c > kio/kfile/kpropertiesdialog.cpp 2d2f00e > kross/ui/plugin.cpp f9f23f9 > > Diff: http://git.reviewboard.kde.org/r/112559/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
