> On Sept. 1, 2013, 5:16 p.m., David Faure wrote: > > Looks fine to me. > > Ivan Romanov wrote: > I don't agree with this patch. I didn't get any notification about this. > So I very ask you before do any changes in cmake rules talk with me. It is > important for me. > > David Faure wrote: > Holy... and here I was, thinking I was doing something good by reviewing > patches for QCA, for lack of reviewers/maintainers. > > Fine, I will definitely stay out of QCA completely, it's not like I ever > wanted to be involved with it. > It's all yours now. > > When objecting to a patch, you might want to give a more detailed > technical argumentation than "I don't agree", BTW. > But I don't care anymore for that argumentation, that's a discussion > between you and Alexander. > > About notifications: you were in the CC for the request, according to > reviewboard. You might want to check which emails reviewboard has for you, or > your mail setup.
Bad ides was to change default values. Now Gentoo building broken also ... yestarday we was building QCA for Qt5 on Windows and couldn't understand why it was installing to "C:\Program Files\" and had -qt5 suffix. So Alexander please revert 1. QCA_INSTALL_IN_QT_PREFIX default value 2. QCA_LIB_SUFFIX defalut value 3. QCA_INCLUDE_INSTALL_DIR and QCA_PRIVATE_INCLUDE_INSTALL_DIR in case when QCA_INSTALL_IN_QT_PREFIX == OFF. Also what for LIB_INSTALL_DIR has different values for Qt4 and Qt5? When I was writing this rules I want to reach the purposes of: 1. Easy installing when building manually. 2. Good adjustability to satisfy any needs. David. Thanks for review and thanks for your care Qca. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/#review39088 ----------------------------------------------------------- On Sept. 3, 2013, 12:42 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111938/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 12:42 p.m.) > > > Review request for KDE Frameworks and Ivan Romanov. > > > Description > ------- > > Use qt5 suffix for files by default when installing a Qt5 version of QCA > > This way coinstallation of Qt4 and Qt5 based QCA is possible by default > > > Diffs > ----- > > CMakeLists.txt 8cff977 > src/CMakeLists.txt 037c9ff > src/config-qca.h.cmake PRE-CREATION > src/qca_plugin.cpp ad810b9 > > Diff: http://git.reviewboard.kde.org/r/111938/diff/ > > > Testing > ------- > > Compiled and installed. > creating a Qt5 package for openSuSE works fine > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
