----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39491 -----------------------------------------------------------
Looks ok to me, apart from the formatting of the documentation blocks. (the "/**" should be alone on its line, everywhere) Maybe Aurélien should review this though. tier1/sonnet/src/ui/spellcheckdecorator.h <http://git.reviewboard.kde.org/r/112281/#comment29095> Last I checked (ok, 8 years ago), doxygen requires this to be on three different lines. (the short form is "/// docu", but we usually rather use the full form instead) - David Faure On Sept. 6, 2013, 5:53 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112281/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 5:53 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Allow setting a custom highlighter on the spell check decorator > > -- > > This is needed in order to use this code from inside KTextEdit which allows > setting a custom highlighter. > This will also be useful for anyone wanting to subclass Sonnet::Highlighter > on a QTextEdit. > > > Diffs > ----- > > tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d > tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 > > Diff: http://git.reviewboard.kde.org/r/112281/diff/ > > > Testing > ------- > > None - my KF5 setup has no dictionaries installed. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
