----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112007/#review39050 -----------------------------------------------------------
Ship it! This one can be committed now, can't it? - David Faure On Aug. 10, 2013, 11:12 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112007/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2013, 11:12 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Use KDE configured shortcuts for Qt default key bindings > > Upgrade our QPlatformTheme to return the keybindings. > If the shortcut exists in KStandardShortcuts and can be configured use that; > otherwise use the default from Qt. > > ---- > > Relies on > https://codereview.qt-project.org/#change,62059 > > A spreadsheet of the bindings between QKeySequence -> KStandardShortcut is > here: > http://static.davidedmundson.co.uk/key_bindings.csv > > I think some may be valid candidates for later adding to KStandardShortcut, > in particular Add Tab. > Not sure on the others. Not everything in QKeySequence::StandardKeys needs to > be configurable IMHO. > > > Diffs > ----- > > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h > edac8dba066b6d9981a6bc509b07e1ecdf0dd516 > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp > d46b5c850d3c6027e592ad0cc17f4449c4fc1e31 > > Diff: http://git.reviewboard.kde.org/r/112007/diff/ > > > Testing > ------- > > None. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
