----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38225 -----------------------------------------------------------
not sure about the directory layout, I'd expect src and tests at the same level... Kévin? staging/frameworkintegration/src/kstyle/kstyle.cpp <http://git.reviewboard.kde.org/r/112175/#comment28248> space after if - David Faure On Aug. 20, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112175/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 5:27 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Make it possible to make sure that we keep reacting properly to ctrl+enter > after switching from QDialog to KDialog by intercepting QDialogButtonBox > creation and injecting the desired shortcut to it. > > > Diffs > ----- > > staging/frameworkintegration/src/kstyle/tests/kstyletest.cpp PRE-CREATION > staging/frameworkintegration/src/kstyle/tests/CMakeLists.txt PRE-CREATION > staging/frameworkintegration/src/kstyle/kstyle.cpp 63506476 > KDE5PORTING.html f820ca1 > staging/frameworkintegration/src/kstyle/CMakeLists.txt 265eff4 > > Diff: http://git.reviewboard.kde.org/r/112175/diff/ > > > Testing > ------- > > Created a "kstyletest" that shows a dialog with a text edit and makes sure > that this works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
