----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/#review38109 -----------------------------------------------------------
I'll trust you with the XCB code I'm totally clueless on that. :-) tier1/kwindowsystem/autotests/CMakeLists.txt <http://git.reviewboard.kde.org/r/112096/#comment28184> You could use X11_FOUND directly, no need for the intermediate HAVE_X11 in such a case. - Kevin Ottens On Aug. 15, 2013, 7:15 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112096/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 7:15 a.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Description > ------- > > Basically a rewrite of the X11 implementation of KWindowEffects to XCB. To > ensure that it doesn't break I added unit tests for everything except > isEffectAvailable (that can hardly be tested as it requires a running KWin). > > Please note: this patch is on top of review #112052 > > > Diffs > ----- > > tier1/kwindowsystem/autotests/CMakeLists.txt 5e05c6d > tier1/kwindowsystem/autotests/kwindoweffectstest.cpp PRE-CREATION > tier1/kwindowsystem/src/kwindoweffects.h bf77e7c > tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112096/diff/ > > > Testing > ------- > > See new unit tests and test application in > kde:scratch/graesslin/kwindoweffectsplugin.git > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
