> On Aug. 13, 2013, 9:31 a.m., Kevin Ottens wrote: > > Ship It!
Wojciech, anything preventing you from pushing this patch? - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/#review37661 ----------------------------------------------------------- On Aug. 13, 2013, 9:31 a.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112046/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 9:31 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > ItemViews use KIconThemes frameworks as test dependency (only for manual > test). But KIconThemes have ItemViews as "hard" dependency. Is is easy to > remove this "pseudo" circular dependency. > Dependency form CMakeLists.txt will be removed in another review (still in > progress) > > > Diffs > ----- > > staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 > > Diff: http://git.reviewboard.kde.org/r/112046/diff/ > > > Testing > ------- > > It builds and tests looks OK (with manual test) > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
