----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111792/ -----------------------------------------------------------
Review request for KDE Frameworks. Description ------- Port KWindowSystemPrivate to QAbstractNativeEventFilter Obviously it's only filtering XCB events and the event filtering code is ported to use XCB data types. With this change the KSystemEventFilter is no longer needed and therefore dropped. Port NETWinInfo::event from XEvent to xcb_generic_event_t Straight forward port just replacing the XLib code by XCB equivalent. The logic of looped event compaction is dropped as inspecting the event queue is not possible on XCB. Port NETRootInfo::event from XEvent to xcb_generic_event_t Straight forward port just replacing the XLib functionality to XCB. The compaction logic got dropped as it was hard disabled anyway. Note: this change currently breaks KWindowSystem as it also needs to be ported. Coding style cleanup of event handling related methods Before adjusting the code let's have a proper coding style. Diffs ----- tier1/kwindowsystem/src/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/src/ksystemeventfilter.cpp PRE-CREATION tier1/kwindowsystem/src/ksystemeventfilter_p.h PRE-CREATION tier1/kwindowsystem/src/kwindowsystem_x11.cpp PRE-CREATION tier1/kwindowsystem/src/netwm.h PRE-CREATION tier1/kwindowsystem/src/netwm.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111792/diff/ Testing ------- Part of it indirectly tested through KWin on 5. Window caption gets updated and that is triggered through NETWinInfo, so I am positively optimistic that all of it works. Thanks, Martin Gräßlin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
