----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review36584 -----------------------------------------------------------
kio/kfile/krecentdocument.cpp <http://git.reviewboard.kde.org/r/111675/#comment26988> What a surprising solution :) I would expect this code to empty the file... It writes an empty file where the existing file is... If it doesn't, it exploits a strange side-effect of QSaveFile :) How about using QFile, and ReadWrite mode, to preserve the contents? - David Faure On July 24, 2013, 8:56 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111675/ > ----------------------------------------------------------- > > (Updated July 24, 2013, 8:56 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port away from kde_file in KRecentDocument (KIO) > > Clean up header > > > Diffs > ----- > > kio/kfile/krecentdocument.cpp 13900c6d0dca0b30cb11a49a29e1918b35f5c9c9 > > Diff: http://git.reviewboard.kde.org/r/111675/diff/ > > > Testing > ------- > > It builds. > > I have also verified that the new code works, setting the file last access > and modification time to the current time. That way, the porting is > equivalent to the former code. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
