----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111539/#review36199 -----------------------------------------------------------
Ship it! staging/xmlgui/src/kcheckaccelerators.cpp <http://git.reviewboard.kde.org/r/111539/#comment26799> Just make the default value QString(), I don't think the empty/null distinction matters here. - David Faure On July 19, 2013, 7:06 p.m., Albert Vaca Cintora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111539/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 7:06 p.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > Moved and updated cmakelists > Added QStringLiteral to string literals > Added a couple of i18n calls that I think were missing > There were no dependencies to remove > > > Diffs > ----- > > staging/xmlgui/src/kundoactions.cpp 2f34a20 > staging/xmlgui/src/kundoactions.h 274915a > staging/xmlgui/src/kcheckaccelerators.cpp d448546 > staging/xmlgui/src/CMakeLists.txt f7dc624 > kdeui/CMakeLists.txt 24b0f1f > > Diff: http://git.reviewboard.kde.org/r/111539/diff/ > > > Testing > ------- > > It builds > > > Thanks, > > Albert Vaca Cintora > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
