> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > <http://git.reviewboard.kde.org/r/110988/diff/5/?file=169752#file169752line476> > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, the coding style in this file is mostly random. I'd reformat it all > to proper coding style in another commit if you're ok with that. > > David Faure wrote: > It's inconsistent, yes -- the usual preferred approach is to fix it while > touching code for other reasons. At least not making it worse, like in the > example I spotted above :) > > A big "reformat everything" commit make "git blame" more cumbersome to > use. So unless it's really a complete mess, I'd rather that any new line of > code uses the kdelibs coding style, and the rest is left untouched until it > actually needs to be touched. > > Martin Klapetek wrote: > Ok then, I'll make sure the style stays the same in areas I touched (or > uses kdelibs coding style for new code). > > As for the rest, it mixes spaces inside brackets with no spaces, brackets > on new line vs. brackets on the same line vs. no brackets at all, different > indentations even inside one method, on some lines tabs are used etc, some > strings are QLatin1String'ed, some not...FileProtocol::mount() starting line > 855 has it even all :) > > David Faure wrote: > Misunderstanding? "stays the same" (as before) isn't the goal, the goal > is an incremental migration to the kdelibs coding style. So you can/should > use the kdelibs coding style for anything you touch.
Misunderstanding :) Done now. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35814 ----------------------------------------------------------- On July 9, 2013, 9:26 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110988/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 9:26 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Ports away kioslave/file from unix/kde specific calls to QFile calls > > > Diffs > ----- > > kioslave/file/file.h 93aeef4 > kioslave/file/file.cpp 6b8b268 > kioslave/file/file_unix.cpp 8b92e06 > > Diff: http://git.reviewboard.kde.org/r/110988/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
