> On July 5, 2013, 3:06 p.m., David Faure wrote: > > staging/kwidgets/src/utils/kcolorscheme.h, line 433 > > <http://git.reviewboard.kde.org/r/111405/diff/1/?file=169137#file169137line433> > > > > Remove this comment, it only applied to one of the two overloads. > > > > We are calling this from the QPA itself, not just from config modules.
Actually not, it applied to both. I re-worded it a little, I think it's more understandable now. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/#review35636 ----------------------------------------------------------- On July 5, 2013, 2:25 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111405/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 2:25 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > We want to deprecate KGlobalSettings, but we need to keep the > createApplicationPalette functionality. > > I decided to move it to KColorScheme. We have 2 kind of users for this method: > - applications that want to do fancy stuff with KDE and integrate better > which will have to depend on KWidgets > - and the rest, who will be able to rely on a properly set QPalette (by > whichever QPlatformTheme we're using on). > > Having moved the method to KColorScheme, seems to me we can use it from our > Platform Theme, because it was doing mostly the same. > > > Diffs > ----- > > kdeui/kernel/kstyle.cpp 9cb0fd2 > kdeui/util/kglobalsettings.h 4b77ed5 > kdeui/util/kglobalsettings.cpp 3e60632 > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 7b660f0 > staging/kwidgets/src/utils/kcolorscheme.h 3ee47be > staging/kwidgets/src/utils/kcolorscheme.cpp a270878 > > Diff: http://git.reviewboard.kde.org/r/111405/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
