----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111171/#review35246 -----------------------------------------------------------
kdeui/util/kglobalsettings.h <http://git.reviewboard.kde.org/r/111171/#comment25817> Unless there's been some discussion and agreement to enforce this alignment (which i would have missed), this suggestion is still wrong. khtml/misc/helper.cpp <http://git.reviewboard.kde.org/r/111171/#comment25816> Unrelated change and is the window color (instead of the titlebar color) really meant here (resp. below for "ACTIVECAPTION" etc.) - Thomas Lübking On June 28, 2013, 5:10 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111171/ > ----------------------------------------------------------- > > (Updated June 28, 2013, 5:10 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Description > ------- > > Deprecate: inactiveTitleColor, inactiveTextColor, activeTitleColor, > activeTextColor in favor of KColorScheme and replace the implementation of > those methods with it. > > > Diffs > ----- > > kdeui/util/kglobalsettings.h 4b77ed5 > khtml/misc/helper.cpp dccb9bf > > Diff: http://git.reviewboard.kde.org/r/111171/diff/ > > > Testing > ------- > > I have compared the colors returned by the methods before and after this > patch, they are close enough. > > Additionally used some apps like filelight with the change, and it seems to > work for them as well. > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
