----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34748 -----------------------------------------------------------
This review has been submitted with commit 119b6630f8403262f9a8e0cb2ee408a3cc803e54 by David Faure to branch frameworks. - Commit Hook On June 20, 2013, 10:22 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111081/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 10:22 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > KIO::Job: more core/gui splitup. > > job->ui() no longer returns a KIO-specific class which was holding > QWidget* window and usertimestamp. It now returns the core-only base > class, like in KJob. The widget-specific information is stored as > a dynamic property into the job, using KJobWidgets API. > > Split out a "job ui delegate extension" in kio, used for the rename > and skip dialog shown by copyjob and movejob. > > REVIEW: 111081 > > > Diffs > ----- > > KDE5PORTING.html 9cac0c69861b999d968c7af5bdeb113b17086b86 > kio/kio/copyjob.cpp e403735f05d644463122728af3a0694454d31367 > kio/kio/job.cpp 365752866ef44d79b42c41af38b446c9fd407c7b > kio/kio/job_p.h e1dd97995825a372d81a8098e0da38bb821b7a20 > kio/kio/jobclasses.h 27a0f12788d35b95934ac714b58df99478e36c31 > kio/kio/jobuidelegate.h 87d9d2777f8bd28e417f54900bf85826fef7fa9b > kio/kio/jobuidelegate.cpp 9f7e1b2093bb22fff5105bdc958ef519bbee8fcb > kio/kio/renamedialog.h 2b9efe21bb5266ced199d2be9b2f8e45df2be4d3 > kio/kio/skipdialog.h 93dd30958377fb997a9f10fa2c3cba7702b14350 > kio/kio/skipdialog.cpp 98251e058704ef7b8f7fc9b349d8da95c121d2ae > kio/tests/jobtest.cpp 7a50857eee19faee995ebbe30e5ba0f954cc858d > kio/tests/kdirmodeltest.cpp 6d9f89070d8579bccb494cbeca080498627e2b1e > kio/tests/kiotesthelper.h 6ecf13409d0117148cc52c774aa5fced37a28e1d > staging/kio/src/core/CMakeLists.txt > 9c243a30a9bda02847335c42efd88b6618862c34 > staging/kio/src/core/abstractjobinteractioninterface.h > 3cf9ffa7e07fa6c51473316b16f8b1b8a7d9b7f2 > staging/kio/src/core/abstractjobinteractioninterface.cpp > a54c5d6da7e0ed0558cd3463f8cfe3755449bbfb > staging/kio/src/core/jobuidelegateextension.h PRE-CREATION > staging/kio/src/core/jobuidelegateextension.cpp PRE-CREATION > staging/kjobwidgets/src/kdialogjobuidelegate.h > f33d34911db53f6e1a90589e70bc9396f049ffc4 > staging/kjobwidgets/src/kdialogjobuidelegate.cpp > a79eda86f8df34c6996a2f7285ba05466c6f8097 > > Diff: http://git.reviewboard.kde.org/r/111081/diff/ > > > Testing > ------- > > make test > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
