----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/#review34019 -----------------------------------------------------------
khtml/xml/dom_docimpl.cpp <http://git.reviewboard.kde.org/r/110876/#comment25033> This isn't about two QDateTimes. It's about one QDateTime (m_creationDate) and one number of seconds, str.toULong(), relative to that creation date. If you don't call fromTime_t(str.toULong) but rather, like the old code, interpret that as a number of seconds relative to the creation date, you won't have the issue of two qdatetimes. In other words, this line should be expire_date = m_creationDate.addSecs(str.toULong()); That's what the old code was doing (via relative=true). No need to change the DocLoader methods further, AFAICS. - David Faure On June 7, 2013, 10:35 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110876/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 10:35 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML) > > > Diffs > ----- > > khtml/khtml_part.cpp a97ca0d8179a438a0ceb713100b5c335995ae9f4 > khtml/misc/loader.h 5e9db0f8baef69c7bb146e4bd6c8cefcdbfe09c2 > khtml/misc/loader.cpp c8812755b99f841f6e7b90da8e154810c1f7c23f > khtml/xml/dom_docimpl.cpp 15f491857ebd17ef21a6df8e187ed16052974cca > > Diff: http://git.reviewboard.kde.org/r/110876/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
