> On June 5, 2013, 9:15 p.m., David Faure wrote: > > kio/kio/slavebase.cpp, line 103 > > <http://git.reviewboard.kde.org/r/110836/diff/1/?file=148651#file148651line103> > > > > Please document the unit being used. > > David Gil Oliva wrote: > I have changed time_t to QDateTime. I don't know where to document it, > since it's an internal variable.
That's fine. My only problem was with int, which was ambiguous (s, ms, us...). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/#review33827 ----------------------------------------------------------- On June 5, 2013, 11:19 a.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110836/ > ----------------------------------------------------------- > > (Updated June 5, 2013, 11:19 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port time_t to QDateTime in SlaveBase (KIO) > > > Diffs > ----- > > kio/kio/slavebase.cpp e5333cfff24d0fdb3eb7f123413e8fb80e504d37 > > Diff: http://git.reviewboard.kde.org/r/110836/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
