> On May 25, 2013, 5:17 p.m., David Gil Oliva wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 346 > > <http://git.reviewboard.kde.org/r/110643/diff/1/?file=146196#file146196line346> > > > > Sometimes there are spaces around parentheses, sometimes there is only > > one space and sometimes there's none. Style should be uniform. What's the > > preferred? (Mine is no spaces)
My preference is no spaces too, but I tried to follow the style already in this file which seemed to have spaces > On May 25, 2013, 5:17 p.m., David Gil Oliva wrote: > > kdeui/dialogs/kpassworddialog.h, line 64 > > <http://git.reviewboard.kde.org/r/110643/diff/1/?file=146195#file146195line64> > > > > Trailing spaces Spaces before and after. It's in the original so I haven't changed it. I can do, but it should be in a different commit. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33132 ----------------------------------------------------------- On May 25, 2013, 12:57 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110643/ > ----------------------------------------------------------- > > (Updated May 25, 2013, 12:57 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Known "bugs" > - there's no clear icon in the text field anymore as I had to port away from > KLineEdit > > Diff shown is without the actual moving for easier reviewing. > > > Diffs > ----- > > kdeui/CMakeLists.txt cfa29ef > kdeui/dialogs/kpassworddialog.h e554c2a > kdeui/dialogs/kpassworddialog.cpp 168271c > kdeui/dialogs/kpassworddialog.ui 95845b9 > kdeui/tests/CMakeLists.txt cd055d5 > kdeui/tests/kpassworddialogtest.cpp b1c55ee > tier1/kwidgetsaddons/src/CMakeLists.txt df22699 > tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 > > Diff: http://git.reviewboard.kde.org/r/110643/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
