----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110209/#review32169 -----------------------------------------------------------
This review has been submitted with commit f8f3f52d8379c05ea9dc7f129c651b904872e36a by George Goldberg to branch frameworks. - Commit Hook On April 26, 2013, 9:02 p.m., George Goldberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110209/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 9:02 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > macro_add_file_dependencies -> set_property > > Change from macro_add_file_dependencies to set_property as advised by the > macro_add_file_dependencies code comments in current cmake git. > > I was getting errors from cmake about macro_add_file_dependencies not being > found, and when I located the file with it in, it said that it was deprecated > anyway, and to replace with set_property. > > > Diffs > ----- > > tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt > 87c7caa433e2916bebd0cab55f0489a3461e8208 > > Diff: http://git.reviewboard.kde.org/r/110209/diff/ > > > Testing > ------- > > Compiles fine now. > > > Thanks, > > George Goldberg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel