----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29574 -----------------------------------------------------------
kio/kio/krun.cpp <http://git.reviewboard.kde.org/r/109549/#comment22055> This is missing const& for the workingDirectory parameter. (Sorry, forgot to publish that review - I hate that on ReviewBoard :-/) - Milian Wolff On March 18, 2013, 7:51 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109549/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 7:51 p.m.) > > > Review request for KDE Frameworks, kdelibs and David Faure. > > > Description > ------- > > Port KRun to use QProcess instead of KProcess. > > Instead of passing around KProcess instances, we simply pass the command with > arguments and the working directory. > > > Diffs > ----- > > kio/kio/krun.cpp 76b7385 > kio/kio/krun_p.h 01abb69 > > Diff: http://git.reviewboard.kde.org/r/109549/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
