Alexander Neundorf wrote: > On Saturday 16 February 2013, Stephen Kelly wrote: >> KDE CI System wrote: >> > -- Performing Test __KDE_HAVE_FPIE_SUPPORT >> > -- Performing Test __KDE_HAVE_FPIE_SUPPORT - Success >> >> I don't think this option makes sense either. By default, Qt requires >> that PIE is used, and it sets Qt5_POSITION_INDEPENDENT_CODE if it does >> need to be used. >> >> CMake already knows how to enable PIE using the POSITION_INDEPENDENT_CODE >> property. > > Ok, so should we unconditionally set CMAKE_POSITION_INDEPENDENT_CODE to > TRUE or only if Qt5_POSITION_INDEPENDENT_CODE is TRUE ?
No. We're doing that currently, but we don't need to do that anymore when we use CMake 2.8.11, because then we can set INTERFACE_POSITION_INDEPENDENT_CODE to true on the Qt5::Core target. Then any targets linking to Qt5::Core have their POSITION_INDEPENDENT_CODE property set to true, and they use -fPIE. > > This means everything else related to fPIE/fPIC can be removed, right ? I think so, yes. Thanks, Steve. _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
