----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review25561 -----------------------------------------------------------
Ship it! Looks good! You can commit, thanks. - Kevin Ottens On Jan. 14, 2013, 11:18 p.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107973/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 11:18 p.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > This changeset removes all gesture facilities from KAction and define them in > KGestureMap. Thanks for the feedback. > > > Diffs > ----- > > KDE5PORTING.html 86dfc1a > kdeui/actions/kaction.cpp b78d1d6 > kdeui/actions/kaction_p.h f87272c > kdeui/dialogs/kshortcutseditor.cpp 5653984 > kdeui/dialogs/kshortcutseditoritem.cpp e85a203 > kdeui/shortcuts/kgesturemap.h 56b42b6 > kdeui/shortcuts/kgesturemap.cpp 1350dbe > > Diff: http://git.reviewboard.kde.org/r/107973/diff/ > > > Testing > ------- > > Code builds OK. KGestureMap is not actually used, though, as > KGestureMap::eventFilter method return false right away. > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
