----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25459 -----------------------------------------------------------
Eek, that's 5 duplicates of the same 4 lines of code. Can't this be done in the Private constructor -- or in a helper method in the Private class? - David Faure On Jan. 13, 2013, 6:59 p.m., Jon Severinsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108389/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2013, 6:59 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > This turns KUser::homeDir (and thus KShell::tildeExpand) closer to > QDir::homePath, which only consults the environment variable. > > It will therefore also fix the kdecore-kshelltest test when HOME is set to a > different directory. > > > Diffs > ----- > > kdecore/util/kuser_unix.cpp 6a612a6 > > Diff: http://git.reviewboard.kde.org/r/108389/diff/ > > > Testing > ------- > > > Thanks, > > Jon Severinsson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
