----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/ -----------------------------------------------------------
Review request for KDE Frameworks and kdelibs. Description ------- In some cases, only part of the first response had arrived when the second s->write(HTTPREQUEST) was executed. Thus the second s->waitForReadyRead() would return when the rest of the first response arrived, which in some cases would be before the second request had left the write buffer That in turn meant that s->close() would be run with a non-empty write buffer, thus only putting the socket in ClosingState rather than UnconnectedState as the test expected. Only tested on the frameworks branch, but it might be applicable to master as well. Diffs ----- kdecore/tests/ktcpsockettest.cpp bfc4212 Diff: http://git.reviewboard.kde.org/r/108380/diff/ Testing ------- Run the test 100 times in a loop without any failures. Thanks, Jon Severinsson
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
