> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > <http://git.reviewboard.kde.org/r/107911/diff/1/?file=101183#file101183line21> > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands
Oh, glad to see that repeating macros in else and endif is no longer required. - Valentin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/#review23985 ----------------------------------------------------------- On Dec. 26, 2012, 10:28 a.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107911/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2012, 10:28 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > For the moment Attica won't build with QT5, so it won't install in a KF5/QT5 > setup. > This fix let KF5/QT5 build without Attica. > > > Diffs > ----- > > CMakeLists.txt e5ef86e > knewstuff/knewstuff3/CMakeLists.txt 8653433 > > Diff: http://git.reviewboard.kde.org/r/107911/diff/ > > > Testing > ------- > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
