On Sunday 30 October 2011 11:45:52 Romain Perier wrote: > Le 23/10/2011 13:27, David Faure a écrit : > > On Saturday 22 October 2011 19:33:23 Romain Perier wrote: > >> Le 14/10/2011 14:33, David Faure a écrit : > >>> Any progress in making it so? > >> > >> The branch frameworks-kcore has been pushed few minutes ago :) . > >> Some classes (like kdirwatch and ksavefile) need to be ported to > >> qfile/qfileinfo in order to remove kde_file.h (I will do it tomorrow, > >> I > >> think). > >> > >> kcoreaddons no longer requires kdecore as runtime dependency (only as > >> static dependency just for some headers). > >> > >> About KGlobal::locale and KGlobal::hasLocale I just disabled the code > >> for now (also I've removed my code with qtextcodec), we need to take a > >> decision about this part. > >> > >> Please review this branch when you've time (there's no hurry) > > > > Very good work, thanks for the separate commits for each change! > > > > I'm done reviewing, see emails here and in private. > > > > Feel free to merge into frameworks after (or before) fixing these > > things. > > > > PS: QStandardPaths was merged into Qt 5! Yay :-) > > There's one method that got renamed, so I'll do the renaming all over > > kdelibs- frameworks once your branch is merged in. > > That's merged, sorry for the delay.
Thanks! There's something weird, though, some classes are duplicated now in kdelibs? E.g. kjob.cpp is both in ./kdecore/jobs/kjob.cpp and in ./tier1/libkcoreaddons/src/jobs/kjob.cpp ? I guess we have some cleanup to do :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org). _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
