aacid added a comment.
In D27973#625707 <https://phabricator.kde.org/D27973#625707>, @heikobecker wrote: > In D27973#625570 <https://phabricator.kde.org/D27973#625570>, @aacid wrote: > > > Heiko, added you ask audex person, i think i have not removed any of the API used by audex either > > > It still uses KCDDB::Config(), KCDDB::Client::config() and KCDDB::Client::submit(), which are all gone. Right, submit needs to be gone, there's nowhere to submit once freedb.org is gone. As for config() there's no config now, so you would need to just remove those calls too. > k3b also breaks due to Client::store(). What k3b here is doing is saving to the "kcddb cache" which i removed because i thought noone is using it, now we could add it back, but i'd rather not and lose that "feature" for 3 reasons: - the cache is "cross application", and that is kind of weird if you ask me. - If we keep the cache we need to keep the kcm module just to be able to say in which folder the cache is, which again is weird because it's something you configure at the "system" level and not at the app level - the cache is centered a bit around the CD "database" model, which with the actual CDDB gone, i am not sure it makes sense to keep. > audiocd-kio doesn't build either, but it looks like it's only missing a few includes. > > I assume you want to get this in until tomorrow night to avoid bug reports about CD lookup not working? Yeah, i mean being part of the release service it *could* wait until next week since we know the thing is going to be released which is one of the reasons for the dependency freeze to be a week before the actual release (make sure your dependencies are released and in place). REPOSITORY R348 KCDDB Library REVISION DETAIL https://phabricator.kde.org/D27973 To: aacid Cc: sitter, heikobecker, rstephenson, kde-doc-english, gennad, fbampaloukas, skadinna
