abika accepted this revision as: abika. abika added a comment.
Good improvement in my opinion! My test results: - The CTRL+SHIFT+UP/DOWN shortcuts work perfectly. Only when unfocusing the navigation bar a second time, the edit mode stays on. It might be a widget problem, but i consider it minor and it happened also before this patch. - Then i set CTRL+UP/DOWN as alternative shortcuts for the same actions to see if this can be used for backwards compatibility: This does not work when trying to unfocusing the navigation bar, the embedded terminal or the command line. All these widgets are capturing the key press and the shortcut action is not activated. So we have to consider that CTRL+UP/DOWN cannot be used anymore as before and users may complain about it. However, this did also not work for the embedded terminal (see bug report) and for the sidebar before this patch. REVISION DETAIL https://phabricator.kde.org/D26291 To: gengisdave, #krusader, yurchor, abika Cc: abika, asensi, yurchor, kde-doc-english, #krusader, gennad, fbampaloukas, nmel, mjanczara, miroslavm, skadinna, janlepper, martinkostolny, gengisdave, andreaska
