dmensinger marked 6 inline comments as done.
dmensinger added inline comments.

INLINE COMMENTS

> rizzitello wrote in mesonimportjob.cpp:47
> "sourcePath" and "bulilddir" appear to be unused here.

Yeah, I haven't touched that code yet. This is still from the barebones 
framework that was created over a year ago. I will replace this function with a 
stub for the time being.

> rizzitello wrote in mesonconfigpage.cpp:178
> auto

I don't know why you would use `auto` here. Should I use `auto` for every 
dynamic_cast?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17278

To: dmensinger, apol
Cc: rizzitello, yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, 
antismap, iodelay, vbspam, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, 
arrowd

Reply via email to