Abella added a comment.
In D13589#279781 <https://phabricator.kde.org/D13589#279781>, @the wrote: > Your steps 1. ... 10. look ok to me -> accepted. > > 11. what are those final points good for? There is a simple list with some tokens / abbrev., not complete sentences. IMHO that change is wrong. Additionally: all these texts are created by a tool (extracted from source code) and will be overwritten the next time I run that tool. This means that these texts have to be in sync with the source code (which also does not support entities). OK! > > > 13. I am not sure, isn't 	 a predefined entity for the tabulator key? Then it would be mis-used in that case. I change all to Tab mode, sorry > How did you take the screenshot? Please do not manually create screenshots! There is a Kwave macro file (scripts/screenshots.kwave) that should be used to create all screenshots, in a unified way, showing the same content for all languages. No working, I'll try again. > BTW: This is a lot of stuff to review and comment within one single pass, it would be easier if things had been split into several steps. Next time, yes. Do I need rewrite this patch? REPOSITORY R347 KWave REVISION DETAIL https://phabricator.kde.org/D13589 To: Abella, the Cc: ltoscano, kde-doc-english, skadinna
