D4849: Export a proper shared library for KDocTools

[David Faure]

View Revision

dfaure added inline comments.

INLINE COMMENTS

View Inlinedocbookxslt.h:1

#ifndef _KDOCTOOLS_XSLT_H_

#define _KDOCTOOLS_XSLT_H_

copyright header missing

View Inlinedocbookxslt.h:13

KDOCTOOLS_EXPORT QString transform(const QString &file, const QString &stylesheet,

const QVector<const char *> &params = QVector<const char *>());

docu?

View Inlinedocbookxslt.h:23

KDOCTOOLS_EXPORT bool saveToCache(const QString &contents, const QString &filename);

docu?

View Inlinedocbookxslt.h:25

KDOCTOOLS_EXPORT void setupStandardDirs(const QString &srcdir = QString());

KDOCTOOLS_EXPORT QString locateFileInDtdResource(const QString &file, const QStandardPaths::LocateOptions option=QStandardPaths::LocateFile);

docu?

View Inlinedocbookxslt.h:26

KDOCTOOLS_EXPORT void setupStandardDirs(const QString &srcdir = QString());

KDOCTOOLS_EXPORT QString locateFileInDtdResource(const QString &file, const QStandardPaths::LocateOptions option=QStandardPaths::LocateFile);

(as expected) docu? ;)
missing spaces around '='

View Inlinedocbookxslt_p.h:1

#ifndef _KDOCTOOLS_XSLT_P_H_

#define _KDOCTOOLS_XSLT_P_H_

missing copyright header

REPOSITORY

R238 KDocTools

REVISION DETAIL

https://phabricator.kde.org/D4849

EMAIL PREFERENCES

https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, dfaure
Cc: Frameworks, Documentation