> On Oct. 29, 2014, 6:47 p.m., Pali Roh?r wrote: > > Should not go this patch also to KDE/4.14 branch? > > Jeremy Whiting wrote: > Yeah, we can cherry pick it to KDE/4.14 once it's pushed. > > Pali Roh?r wrote: > It is already in master: > http://quickgit.kde.org/?p=kopete.git&a=commit&h=def471bc7a154ae5749e2fcd31046ed03522c94e > > Jeremy Whiting wrote: > Oops I was thinking this was the other review. Pushed to KDE/4.14 just > now too. thanks for reminding me. > > Pali Roh?r wrote: > You backported bad commit, see: > http://quickgit.kde.org/?p=kopete.git&a=commit&h=782b12451f7e20539678d8c389e29f092bdf0001
Ok, I undid that commit on KDE/4.14 just now. Also, this right commit shouldn't be backported to KDE/4.14 because it's frozen for translation changes, including docs. - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120736/#review69499 ----------------------------------------------------------- On Oct. 29, 2014, 2:04 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120736/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 2:04 p.m.) > > > Review request for Documentation, Burkhard L?ck and Pali Roh?r. > > > Repository: kopete > > > Description > ------- > > Add faqs from the old kopete.kde.org to docbook faq section. > > > Diffs > ----- > > doc/index.docbook b55fd881e36669ad9870b2250680bf01199b3faf > > Diff: https://git.reviewboard.kde.org/r/120736/diff/ > > > Testing > ------- > > I'm not set up to build kdelibs4 based applications at this point, but can be > if needed. I thought I would post this for those with docbook experience to > check my changes. > > > Thanks, > > Jeremy Whiting > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20141030/e2a61890/attachment.html>
