On Thu, Apr 24, 2025 at 7:16 AM Stefano Crocco <stefano.cro...@alice.it> wrote:
> On mercoledì 23 aprile 2025 12:39:29 Ora legale dell’Europa centrale Ben > Cooksley wrote: > > In the absence of KatePart, is there any other KPart that supports > viewing > > text/plain? > > > > Looking at your overall CI log as well as your .kde-ci.yml I don't see > > either a build or runtime dependency on Kate, so it won't be around in > the > > CI environment. > > That would explain why autotests/konqviewtest.cpp#L42 is false. > > Yes, it could be displayed by WebEnginePart. If this happened, the test > would > fail, but on a different line: not 42 but 45. Still, without Kate in the > environment, the test is pointless. > > > > > What sort of link is being activated here? Could it be KIO / Konqueror > > having an issue with understanding the URL schema / not having something > to > > render the returned mimetype? > > Reading the code it appears to be doing similar things to KonqViewTest, > so > > fixing one will likely fix the other. > > It is a plain text file and WebEnginePart should be able to display it > and, > unlike the other test, this shouldn't make the test fail. > > Having katepart available, however, is necessary for these tests as they > seem > to assume it's available. Should I just add a line with > frameworks/ktexteditor > under the 'require' section of .kde-ci.yml and create a normal merge > request > for this change? > Yes, that will be sufficient as it seems that KatePart is part of frameworks/ktexteditor. > > > Cheers, > > Ben > > Thanks > > Stefano > Cheers, Ben
