On Freitag, 14. Juni 2024 00:21:41 CEST Albert Astals Cid wrote: > El dijous, 13 de juny del 2024, a les 22:37:04 (CEST), Ingo Klöcker va > > escriure: > > On Mittwoch, 12. Juni 2024 00:22:35 CEST Albert Astals Cid wrote: > > > kwalletmanager - 3rd week > > > > > > * https://invent.kde.org/utilities/kwalletmanager/-/pipelines/711185 > > > > > > * appstream test fails because https://apps.kde.org/kwalletmanager5 > > > > > > doesn't exist > > > > This will be fixed by > > https://invent.kde.org/websites/apps-kde-org/-/merge_requests/94 > > Proof: > > https://invent.kde.org/kloecker/apps-kde-org/-/jobs/1897729/artifacts/ > > external_file/public/kwalletmanager5/index.html > > Can we have someone that knows about that code review it or should i just > press the bottom and YOLO it? [ the html_test on CI fails, is that expected > when run on a repo fork? ]
The html_test always fails for MRs. It checks URLs like https://kloecker.local-kde.org/-/apps-kde-org/-/jobs/1897729/artifacts/public/ bovo/ which will never work because unlike on the real page with a real web server there are no redirects to or automatic loading of https://kloecker.local-kde.org/-/apps-kde-org/-/jobs/1897729/artifacts/public/ bovo/index.html Fixed with the following MR which disables the test for all non-protected branches where it will anyway fail https://invent.kde.org/websites/apps-kde-org/-/merge_requests/95 Regards, Ingo
signature.asc
Description: This is a digitally signed message part.
