Hi, Thanks for the clarity on the license. Snaps are not ready for qt6 at all, hence the release branch only. I wasn't doing MRs as I am the sole maintainer of snaps and I only have another day to get this transition done before my internet gets cut off. I wanted to get 23.08.2 release done before this happens. I will do MR as requested and hope for the best. Scarlett
On Wed, Oct 18, 2023 at 12:31 AM Carl Schwan <c...@carlschwan.eu> wrote: > > I'm a bit confused as to why this was only added to the release/23.08 branch > and not master as well. > > Also the licensing issue was not solved correctly, see the following patch: > https://invent.kde.org/accessibility/kontrast/-/commit/17ece874e0f2fda3f8a6553ac7386b911faad405 > > In the future, please open a merge request. This is the sort of issues that > can > be easily caught up in code reviews ;) > > Cheers, > Carl > > On Tue, Oct 17, 2023, at 11:07 PM, Scarlett Moore wrote: > > Fixed! > Scarlett > > On Tue, Oct 17, 2023 at 1:54 PM Albert Astals Cid <aa...@kde.org> wrote: > > > > Please work on fixing them, otherwise i will remove the failing CI > > jobs on their 4th failing week, it is very important that CI is passing for > > multiple reasons. > > > > Good news: We're down to only 1 non passing repository. > > > > = FAILING UNIT TESTS = > > > > kontrast: (1st week) > > * https://invent.kde.org/accessibility/kontrast/-/pipelines/501951 > > * reuse check is failing > > > > > >
