El dilluns, 3 d’octubre de 2022, a les 19:07:12 (CEST), Tobias Leupold va escriure: > Am Montag, 3. Oktober 2022, 15:47:15 CEST schrieb Albert Astals Cid: > > El dilluns, 3 d’octubre de 2022, a les 15:38:29 (CEST), Albert Astals Cid > > va> > > escriure: > > > El diumenge, 2 d’octubre de 2022, a les 17:57:10 (CEST), Johannes > > > Zarl-Zierl> > > > > > > va escriure: > > > > Hi Albert, > > > > > > > > Thanks for the change ! > > > > > > > > Am Sonntag, 2. Oktober 2022, 07:51:04 CEST schrieb Albert Astals Cid: > > > > > Nothing broke but at least it seems the po files did not get > > > > > commited > > > > > to > > > > > these projects (maybe there are some more problematic repots, please > > > > > check > > > > > yours if it's not part of KDE Gear, KDE Framworks or Plasma, those > > > > > are > > > > > the > > > > > ones i did check more thoroughly and fix if found something) > > > > > > > > > > digikam > > > > > gcompris > > > > > kaffeine > > > > > kbibtex > > > > > kphotoalbum > > > > > kst-plot > > > > > rkward > > > > > skrooge > > > > > trojita > > > > > ubiquity-slideshow-neon > > > > > > > > > > Because it is ignoring the po folder at the .gitignore file level, > > > > > please > > > > > don't do that anymore. > > > > > > > > I'm not sure why kphotoalbum is listed here - the "Sync po/docbooks > > > > with > > > > svn" commit did land in our repo and po is not listed in our > > > > .gitignore. > > > > > > It seems I failed reporting kphotoalbum, apologies. > > > > Actually no I was right, the .gitignore has > > > > kphotoalbum > > > > in it > > > > which is making git ignore the > > > > po/language/docs/kphotoalbum > > > > folders. > > Hey Albert, > > Thanks for pointing this out! > > I think this is a remnant from old times where we didn't build inside of a > "build/" directory. Which is possibly also the case for most of the other > entries in .gitignore, but that's another thing. > > I hope I fixed this with commit ab87cf51, is it okay now?
Looks good :) > > Tobias > > > Cheers, > > > > Albert > > > > > > > > > This is a heads up, as a developer there's nothing you need to > > > > > > > do, > > > > > > > at > > > > > > > most > > > > > > > remove the po/ folder from .gitignore if for some reason it is > > > > > > > there. > > > > > > > > Should I add "ki18n_install(po)" to my CMakeLists.txt? > > > > > > Yes, well no because Christophe already added it. > > > > > > Cheers, > > > > > > Albert > > > > > > > Cheers, > > > > > > > > Johannes
