On Mon, May 18, 2020 at 8:59 PM Ivan Romanov <driz...@zoho.eu> wrote:
>
> Hello.
>
> Today I added generated file to QCA repo. This commit
> https://invent.kde.org/libraries/qca/-/commit/cf929ce541b48e36a54691a37b31211d17334bf7.
> And got such email mesage: The files marked with a * at the end have a
> non valid license. Please read:
> https://community.kde.org/Policies/Licensing_Policy and use the headers
> which are listed at that page.
>
> So which header/license I should use in my case?
I'd use the same license as for the main project -- but someone else
might have a better reasoned opinion than just "that would make sense
to me" ;)

However looking at your particular commit I notice a few things:

1. Generated files being committed
2. The actual source (CSV) not being committed (judging by the diff)
3. The script to generate things lacks a license

If at all feasible I would suggest a different approach: commit the
script and CSV, and have a custom CMake target call the script to
generate sources and make that custom target a dependency of your
actual target that depends on the generated files. This way you can
add the generated files to your .gitignore and you neatly sidestep the
whole problem. As a bonus, people cannot forget to remember to run the
script on a fresh clone or whenever the CSV data changes (future TLS
versions?).

Even if that is not feasible I suggest you still commit the CSV,
because AFAIK licenses like the GPL and LGPL require that recipients
of the source code be able to build it. (I.e. they need to be able to
re-generate the files and that requires the original data).

Regards,

- Johan

Reply via email to