The commit:

https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1

results in apparently public symbols going missing

https://paste.kde.org/pj1kbp9un

>From IRC.

[08:43] <acheronuk> sitter: does this break ABI in frameworks?
https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1
[08:45] <acheronuk> sitter: https://paste.kde.org/pj1kbp9un
[08:59] <sitter> acheronuk: assuming activitiesmodel is in fact a public
class: yes
[08:59] <sitter> adding a const anywhere changes the call signature
[08:59] <sitter>
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
[09:00] <sitter> You cannot...For existing functions of any type:change
its signature. This includes:changing any of the types of the arguments
in the parameter list, including changing the const/volatile qualifiers
of the existing parameters (instead, add a new method)

Confirmation that this is either an issue that needs to be sorted, or
one where there is no impact is appreciated.

Rik Mills

Reply via email to