> > ok, tests pass now here locally too, *but* they don't finish, i.e. the > testdaemon process keeps running forever, does anyone else see this?
It turns out I hadn't terminated the QProcess after the test case had finished executing. This is fixed in the latest commit to master. Can you please update your Readme.md? > I have done this, with a small note under the heading mentioning that it is a GSoC project. Now, we can start discussing the shipping of the ioslave and whether it's a better fit for KDE extragear or for mainline KDE Frameworks. I would be happy with releasing it in extra gear initially and later moving it to KDE Applications/Frameworks if there is enough interest from the community to do so. On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid <[email protected]> wrote: > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > escriure: > > Hi! > > > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > > Project. Now that most of the changes which I wished to make in > > Dolphin relevant to the ioslave are part of master, I wish to ship the > > ioslave soon. > > > > The project is now in KDE review and is awaiting feedback. The link > > for the same can be found here: > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 > 672ac907b8 > > > > The source of the project can be found here: > > https://cgit.kde.org/kio-stash.git/ > > Can you please update your Readme.md? > > # GSoC 2016 File Stash project for KDE > > sounds bad, we're not in 2016 anymore, > > # File Stash kioslave > > sounds more clear of what it is. > > Cheers, > Albert > > > > > Thanks. > > > -- arnav dhamija
