> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the database after a Frameworks > update, that would be good. > > Would it be better to read the old location if found and reserve the new > one only for new database (or rebuilt) and switch to the new one for > Frameworks 6? > > James Smith wrote: > Regeneratable data isn't config, so this change isn't as important as the > config location change between SC4 and KF5. The config data location switch > was mandatory for KF5-based apps. I think we can safely switch regeneratable > data at any time.
Did you try it in practice? I'm talking about time and I/O which is not visibile in the normal usage because the full indexing already happened. Moreover the old index will be left there unused. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review102382 ----------------------------------------------------------- On Dic. 12, 2016, 12:06 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129605/ > ----------------------------------------------------------- > > (Updated Dic. 12, 2016, 12:06 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Move the database into the XDG cache path. > > > Diffs > ----- > > src/engine/global.cpp 4f511ac08f0fd18bd3c78b794f4ba7ccef88e75b > src/tools/balooctl/main.cpp 2a6b175ee599d7ca713adcbed80d3bd128e9dd63 > > Diff: https://git.reviewboard.kde.org/r/129605/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
