----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/#review96765 -----------------------------------------------------------
As there is no bugreport for this one to comment on, an idea how this can happen: 1. A file is moved to a different directory 2. The old directory is deleted The docID is a concatenation of stat.device | stat.inode, thus won't change by moving the file. - Stefan Brüns On June 16, 2016, 5:50 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128189/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 5:50 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > We can have cases when deleting a directory from DocumentUrlDB when we have > some children stored under it which actually don't exist on the file system. > This can happen when the dir is being removed from DB because it doesn't > exist on the filesystem. > > We do need to work on cleaning up the DB when we encounter such behaviour or > even better figure out why it is happening and preventing it from happening. > > > Diffs > ----- > > src/engine/documenturldb.h 9bd5bb5 > > Diff: https://git.reviewboard.kde.org/r/128189/diff/ > > > Testing > ------- > > Fixed crash on CoLa's laptop. > > > Thanks, > > Pinak Ahuja > >
