> On Feb. 26, 2016, 8:48 p.m., Boudhayan Gupta wrote:
> > src/externalextractor.cpp, line 98
> > <https://git.reviewboard.kde.org/r/127179/diff/2/?file=445604#file445604line98>
> >
> > Does it not build without the const (in Q_D(const Ext...))? You
> > shouldn't have to put qualifiers inside the Q_D.
It doesn't build without it. Gives me
`error: invalid conversion from 'const
KFileMetaData::ExternalExtractor::ExternalExtractorPrivate*' to
'KFileMetaData::ExternalExtractor::ExternalExtractorPrivate*'`
^
- Varun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127179/#review92816
-----------------------------------------------------------
On Feb. 26, 2016, 6:50 p.m., Varun Joshi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127179/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 6:50 p.m.)
>
>
> Review request for Baloo, Boudhayan Gupta and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> 1. Add the ExternalExtractor class that wrap the external extractor process
> into the standard Extractor interface
> 2. Modify ExtractorCollection to enable it to support ExternalExtractors
> 3. Added an example PyPDF2 extractor plugin
>
>
> Diffs
> -----
>
> README.md 19b1a26a241e6a35c636aaf8162afe762018f073
> autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1
> autotests/externalextractortest.h PRE-CREATION
> autotests/externalextractortest.cpp PRE-CREATION
> src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5
> src/config-kfilemetadata.h.in PRE-CREATION
> src/externalextractor.h PRE-CREATION
> src/externalextractor.cpp PRE-CREATION
> src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e
> src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401
> src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250
> src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77
> src/extractors/externalextractors/CMakeLists.txt PRE-CREATION
> src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION
> src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/127179/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Varun Joshi
>
>
