On Sat, Feb 6, 2016 at 10:21 AM, David Faure <[email protected]> wrote: > On Tuesday 22 December 2015 21:22:15 Robby Stephenson wrote: > > Bringing in the small amount of code from libkonq/favicons to KIO seems > > like a feasible approach. I'm willing to test and fix bugs there, too. > > Unaware of this discussion (no time to read kde-devel), I have done exactly > this during January. KIO (starting from 5.19) now has a KIOGui library > with a > FavIconRequestJob, which removes the dependency on the kded module > provided by libkonq (I'll kill it soon, since it wasn't released). > KIO::favIconForUrl(), which you mention in your mail, now uses the cache > where FavIconRequestJob stores icons. Please port tellico to > FavIconRequestJob and report any problems to me (or on the > kde-frameworks-devel list, or in bugzilla). I'm interested in your feedback > about it (but I guarantee it's good quality to start with, I wrote > extensive > unit tests for it). >
Fabulous. Thanks, David. I'd started a little work on it but had gotten bogged down in figuring out how to actually test chided modules. I'll take a look at FavIconRequestJob and port Tellico over to it. Robby
