----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86535 -----------------------------------------------------------
I'm adding the release team since maybe we can delay the release of Baloo or make a special bug fix release with this patch. Shipping Baloo with a broken kioslave is not good. src/lib/searchstore.cpp (line 103) <https://git.reviewboard.kde.org/r/125544/#comment59586> Say we have 50 results limit = 10 offset = 5 So we want results from [5, 14] With this code - for (i = 5; i < 10; i++) We we would get [5, 10). Could you please fix this? I think a simple `i < limit + offset` would do. src/lib/searchstore.cpp (line 114) <https://git.reviewboard.kde.org/r/125544/#comment59587> The entire code in this else case is absolutely rubbish. The person implementing it should feel bad (me). We seem to be completly ignoring the offset over here. - Vishesh Handa On Oct. 7, 2015, 10:27 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125544/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 10:27 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > The bug is obvious, old code uses limit instead of (limit > 0), which > gracefully handles limit < 0 case (means everything). > > After offset is introduced, limit < 0 case is not handled properly. > > This patch contains following changes: > 1. make offset uint, m_offset is uint in Query already. > 2. handle limit < 0 case properly. > > > Diffs > ----- > > src/lib/searchstore.h 17b4263 > src/lib/searchstore.cpp a2e7749 > > Diff: https://git.reviewboard.kde.org/r/125544/diff/ > > > Testing > ------- > > baloosearch:/ doesn't return anything because of this, now it properly > returns result. > > > Thanks, > > Xuetian Weng > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
