----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86228 -----------------------------------------------------------
src/file/unindexedfileindexer.cpp (line 59) <https://git.reviewboard.kde.org/r/125481/#comment59433> Are you sure this is the right thing to be doing? I'm imagining the case when the filename has changed when `baloo_file` was not running. - Vishesh Handa On Oct. 2, 2015, 10:44 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125481/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 10:44 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Bugs: 353011 > http://bugs.kde.org/show_bug.cgi?id=353011 > > > Repository: baloo > > > Description > ------- > > Add a new Runnable which checks for unindexed files and indexes them. > > > Diffs > ----- > > src/file/CMakeLists.txt 306a211 > src/file/fileindexscheduler.h 1479063 > src/file/fileindexscheduler.cpp 5bb55ea > src/file/indexerstate.h 8032280 > src/file/unindexedfileindexer.h PRE-CREATION > src/file/unindexedfileindexer.cpp PRE-CREATION > src/tools/balooctl/main.cpp 305c82b > > Diff: https://git.reviewboard.kde.org/r/125481/diff/ > > > Testing > ------- > > Manual testing: created a new file with baloo_file killed. Ran baloo_file and > then balooctl check, new file was indexed. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
