----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125306/ -----------------------------------------------------------
Review request for Baloo and Vishesh Handa. Repository: baloo Description ------- Also there is no need to allocate memory for the QProcess on the heap. Calling close kills the baloo_file_extractor before we destroy the object therefore preventing the warnings of the type QProcess destroyed while baloo_file_extractor is still running. Diffs ----- src/file/extractorprocess.cpp 67585a6 src/file/extractorprocess.h 82bab80 Diff: https://git.reviewboard.kde.org/r/125306/diff/ Testing ------- baloo works as before Thanks, Pinak Ahuja
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
