----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125302/#review85637 -----------------------------------------------------------
Ship it! Looks good some minor suggestions, * Forgot to add the description for the config command to balooctl :) * maybe we can check for plural as well as singular forms of commands (includeFolder(s))? * If I type in balooctl config add <wrong command> [folders..] I get no output, show some error maybe? - Pinak Ahuja On Sept. 18, 2015, 7:36 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125302/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 7:36 p.m.) > > > Review request for Baloo and Pinak Ahuja. > > > Repository: baloo > > > Description > ------- > > This will allow users to easily modify their Baloo configuration without > having to mess with config files. Plus we have a large amount of error > handling in case the user enters an incorrect value. > > > Diffs > ----- > > src/lib/indexerconfig.h 8aaed81 > src/lib/indexerconfig.cpp e518b94 > src/tools/balooctl/CMakeLists.txt 3e25685 > src/tools/balooctl/command.h PRE-CREATION > src/tools/balooctl/command.cpp PRE-CREATION > src/tools/balooctl/configcommand.h PRE-CREATION > src/tools/balooctl/configcommand.cpp PRE-CREATION > src/tools/balooctl/main.cpp 696077d > > Diff: https://git.reviewboard.kde.org/r/125302/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
