> On Sept. 16, 2015, 7:32 p.m., Albert Astals Cid wrote: > > Are we compiling this file twice?
Yes, we compile indexerstate.h twice, first in balooctl and also in baloomonitorplugin. Actually it is compiled in baloo_file as well but it just uses the enum and not the strings. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/#review85510 ----------------------------------------------------------- On Sept. 16, 2015, 11:36 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125257/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 11:36 a.m.) > > > Review request for Baloo, Localization and Translation (l10n) and Vishesh > Handa. > > > Repository: baloo > > > Description > ------- > > Delibrately left of baloo-monitor as it will not be the final public facing > interface and will be removed soon. (once I fix this > https://git.reviewboard.kde.org/r/124720/) > > > Diffs > ----- > > src/file/indexerstate.h b2bc8f4 > src/qml/experimental/CMakeLists.txt 335cc9e > src/qml/experimental/Messages.sh PRE-CREATION > src/tools/baloo-monitor/CMakeLists.txt cf9ac51 > src/tools/balooctl/Messages.sh 87bd496 > > Diff: https://git.reviewboard.kde.org/r/125257/diff/ > > > Testing > ------- > > Not too sure how to test it? Also I hope C++ qml plugins will work properly > with i18n? > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
