----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124836/#review84088 -----------------------------------------------------------
Ship it! Go ahead. This makes sense. But perhaps you want to move to a better way instead of just counting lines. Maybe some kind of specification on what should be sent/received. The extractor could always send some kind of message when it started indexing and finished indexing each file. - Vishesh Handa On Ago. 20, 2015, 12:12 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124836/ > ----------------------------------------------------------- > > (Updated Ago. 20, 2015, 12:12 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Since we emit the filenames before we start indexing them, for diagnostic > reasons, simply counting the number of files written to stdout is not enough > we need to make sure baloo_file_extractor has commited before it is destroyed > (when indexing the last batch or suspending it). So now we wait for > baloo_file_extractor to write "batch commited" to stdout before the > ExtractorProcess emits done. > > > Diffs > ----- > > src/file/extractor/iohandler.cpp 0a4a91d > src/file/extractorprocess.cpp 612ce5b > > Diff: https://git.reviewboard.kde.org/r/124836/diff/ > > > Testing > ------- > > Occasionally, baloo was not being able to resume from suspended state after > my previous patch which was most likely because we were killing > baloo_file_extractor while committing, messing up the index. This seeems to > be fixed now. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
