----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124439/#review83091 -----------------------------------------------------------
Ship it! Sounds good. Sorry for the delay. - Vishesh Handa On July 24, 2015, 1:11 p.m., Dāvis Mosāns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124439/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 1:11 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Currently it would say it's skiping file because it's already indexed, but > actually it wouldn't skip and raise assert > > $ balooctl index file.txt > Skipping: file.txt Reason: Already indexed > Indexing file.txt > ASSERT: "!url.isEmpty()" in file > /mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60 > > > Diffs > ----- > > src/tools/balooctl/main.cpp e8f29b21e0100508f39ba5a6a45536979803f144 > > Diff: https://git.reviewboard.kde.org/r/124439/diff/ > > > Testing > ------- > > Verified that now it skips file and don't cause assert. > > > Thanks, > > Dāvis Mosāns > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
