----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124244/#review82381 -----------------------------------------------------------
Ship it! Maybe you want to move the Logger into `baloo_file` instead of the extractor? That way we can log when the extractor crashes or when we kill it cause it is consuming too much memory or CPU? src/file/extractor/app.cpp (line 65) <https://git.reviewboard.kde.org/r/124244/#comment56769> You're leaking memory over here. src/file/extractor/logger.h (line 37) <https://git.reviewboard.kde.org/r/124244/#comment56768> In the future, maybe we can add a reason as to why it was Ignored? - Vishesh Handa On July 3, 2015, 5:10 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124244/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 5:10 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add an option to log every file processed by extractor along with the result > i.e. indexed or ignored, time taken to index the file. Logging can be enabled > by either a config option or by setting the env variable BALOO_EXTRACTOR_LOG > manually. > > > Diffs > ----- > > src/file/extractor/CMakeLists.txt 13fe7aa > src/file/extractor/app.h 79a3dac > src/file/extractor/app.cpp 8868b08 > src/file/extractor/logger.h PRE-CREATION > src/file/extractor/logger.cpp PRE-CREATION > src/file/fileindexerconfig.h 4c7dfcc > src/file/fileindexerconfig.cpp ce3b2b5 > src/file/main.cpp 0fabfd2 > > Diff: https://git.reviewboard.kde.org/r/124244/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
